Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose User.reload as beta API #10039

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Expose User.reload as beta API #10039

merged 1 commit into from
Dec 12, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 10, 2024

CloudBees CI in HA mode sometimes needs to reload the list of Users in response to changes on disk. #8544 suffices when there is merely a configuration change to a loaded User object (e.g., saving email address) but not in all cases, such as a new User being defined. Calling Jenkins.reload is much too heavyweight.

Testing done

Covered by an automated test in CloudBees CI.

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@jglick jglick requested a review from Vlatombe December 10, 2024 00:04
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 10, 2024
@timja timja added the skip-changelog Should not be shown in the changelog label Dec 10, 2024
@timja timja merged commit d773eb9 into jenkinsci:master Dec 12, 2024
15 checks passed
@jglick jglick deleted the User.reload branch December 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants